Skip to content

[snowflake] Support single line comments starting with '#' or '//' - #264

Merged
nickolay merged 1 commit into
apache:mainfrom
eyalleshem:snowflake_comment
Sep 7, 2020
Merged

nickolay merged 1 commit into
apache:mainfrom
eyalleshem:snowflake_comment

Conversation

@eyalleshem

Copy link
Copy Markdown
Contributor

Add support for that in the snowflake dialect

@eyalleshem eyalleshem changed the title Snowflake db supports signle line comments that starts with '#' or '/' , Ad support to snowflake-db single line comments that starts with '#' or '/' , Aug 16, 2020
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 210775918

  • 52 of 54 (96.3%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 91.995%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/tokenizer.rs 27 29 93.1%
Totals Coverage Status
Change from base Build 205645794: 0.05%
Covered Lines: 4597
Relevant Lines: 4997

💛 - Coveralls

@nickolay nickolay changed the title Ad support to snowflake-db single line comments that starts with '#' or '/' , [snowflake] Support single line comments starting with '#' or '//' Sep 7, 2020
@nickolay
nickolay merged commit 1c6077c into apache:main Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants